Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add read abiotic ranges function #195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add read abiotic ranges function #195

wants to merge 1 commit into from

Conversation

hansvancalster
Copy link
Contributor

A function to read the data from https://zenodo.org/records/10533792.

This is a quick and dirty implementation - so a good review round will be needed.

@florisvdh I haven't updated NEWS or bumped version because I imagine that you may prefer setting up a development branch first? Otherwise I can add it to this branch, just let me know.

@florisvdh
Copy link
Member

@hansvancalster thanks for giving this a start! As already talked about, we'll look into this further together. I plan to come back to it later this week.

The target branch should be dev_nextrelease (not main), and it has got updated recently. So you need to update the target branch of this PR (I suppose you can, otherwise I can) and pull dev_nextrelease into read_far.

If you want a clean start instead, then, after pulling dev_nextrelease, you can either start a new branch from there, cherry-pick ebafc10 and start a new PR, or update the existing branch by rebasing read_far onto dev_nextrelease, then force-push here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants